Project

General

Profile

Task #17949

doMatch(): simplify data structures, integrate a cache

Added by Shuvam Misra about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Abhishek Jayswal (Tantiv4)
Start date:
16/02/2024
Due date:
29/02/2024
% Done:

100%

Estimated time:
8.00 h

Description

Modify doMatch() to use the newer data structures (where arrays of structs each with two fields have been replaced with hashmaps).

Make doMatch() work with a cache where

  • all rulesets and schemas of one slice are loaded at a time
  • all internal references from one ruleset to another are done through pointers from one struct to another

Files

Screenshot from 2024-03-06 23-08-12.png (220 KB) Screenshot from 2024-03-06 23-08-12.png test case passed results Abhishek Jayswal (Tantiv4), 06/03/2024 11:13 PM
#1

Updated by Shuvam Misra about 1 year ago

  • Due date set to 29/02/2024
#2

Updated by Shuvam Misra about 1 year ago

  • Assignee set to Abhishek Jayswal (Tantiv4)
#3

Updated by Shuvam Misra about 1 year ago

  • Status changed from New to In Progress
#4

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

Schema testcase pushed to github commit-id 035eba3

#5

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

  • Estimated time set to 8.00 h
  • % Done changed from 0 to 60
#6

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

Cache Data Integration with Do_Match() completed. working on unit test cases.

#7

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

do_match unit test case development is under progress

#8

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

  • % Done changed from 60 to 80

With the new data struct able to pass the basic ,exit and return unit test case. This test case verify the core functionality of the Do_Match function.

#9

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

  • % Done changed from 80 to 90

Test case match pattern, verify data & collect action is completed.

Pending BRE and WF test cases.

#10

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

all the test case are reworked, working on four test case which is getting failed.
some changes need to be done in ThenCall and ElseCall functionality

commint ID e633d07

#11

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

All the unit test cases are passed. attached the screen shot for same.
commit id# https://github.com/abjayswal/crux/commit/dd5d152f696734dc20e7fe8a4a0a707a43d0af27

#12

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

Changes submitted for stats implementation, commit#a7c8989

#13

Updated by Shuvam Misra about 1 year ago

  • Target version changed from Sprint 29 Feb to Sprint 15 Mar
#14

Updated by Shuvam Misra about 1 year ago

If this has been in 100% completed state for 13 days, Sachin, can you please close this?

#15

Updated by Shuvam Misra about 1 year ago

Abhishek, whenever one of your tasks reaches 100% completion state, and you feel that there's nothing more for you to do, only Sachin needs to test, then please set the status to "testing".

#16

Updated by Shuvam Misra about 1 year ago

Abhishek and Sachin, please close this task today, or change the percentage done from 100% to, say, 90%. The percentage was set to 100% 14 days ago.

#17

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

  • % Done changed from 100 to 90
#18

Updated by Abhishek Jayswal (Tantiv4) about 1 year ago

  • Status changed from In Progress to Testing

matching pattern have issue, when the external caller pass the ruleset to match say "mrp": "50.80", This value during matchpatten expect it as float but since in json it is as string. Wrote a rapper convertTermAttrVal() which will convert the json value into the expected datatypes then pass to makeComparison()

Moving status to testing.

#19

Updated by Shuvam Misra about 1 year ago

  • % Done changed from 90 to 100
#20

Updated by Shuvam Misra about 1 year ago

  • Status changed from Testing to Closed

Also available in: Atom PDF